Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Varnish k8s plugin support #1282

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Varnish k8s plugin support #1282

merged 7 commits into from
Jul 23, 2024

Conversation

algchoo
Copy link
Contributor

@algchoo algchoo commented Jul 15, 2024

Description

This PR updates the Varnish mixin to support the k8s plugin

Logs for this integration required sidecar forwarding and having alloy read from an actual file on the container's filesystem, rather than reading logs from the container's stdout. With this, even though it's k8s we're still going to have a filename label and it makes sense here.

Changes

Caleb-Hurshman
Caleb-Hurshman suggested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Caleb-Hurshman Caleb-Hurshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change before I approve

varnish-mixin/dashboards/varnish-overview.libsonnet Outdated Show resolved Hide resolved
BominRahmani
BominRahmani approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@BominRahmani BominRahmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! (fix that problem caleb pointed out) ✅

@algchoo algchoo marked this pull request as ready for review July 18, 2024 13:42
@algchoo algchoo requested a review from a team as a code owner July 18, 2024 13:42
Caleb-Hurshman
Caleb-Hurshman approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@Caleb-Hurshman Caleb-Hurshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ✅

Dasomeone
Dasomeone reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a documentation question from my end.

varnish-mixin/dashboards/varnish-overview.libsonnet Show resolved Hide resolved
Dasomeone
Dasomeone approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks Austin! Forgot to approve in the morning so doing so now

@Dasomeone Dasomeone enabled auto-merge (squash) July 22, 2024 15:23
auto-merge was automatically disabled July 22, 2024 18:31

Head branch was pushed to by a user without write access

@Dasomeone Dasomeone merged commit 33fd33f into grafana:master Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dasomeone Dasomeone Dasomeone approved these changes

@BominRahmani BominRahmani BominRahmani approved these changes

@Caleb-Hurshman Caleb-Hurshman Caleb-Hurshman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@algchoo @Dasomeone @BominRahmani @Caleb-Hurshman